Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show file extensions #128

Open
jeffgca opened this issue May 10, 2021 · 7 comments
Open

Always show file extensions #128

jeffgca opened this issue May 10, 2021 · 7 comments

Comments

@jeffgca
Copy link

jeffgca commented May 10, 2021

NB: Feature requests will only be considered if they solve a pain

Summary

Most OS file explorers show file extensions. So should we.

Problem

  • Files in drive don't display file extensions, but the resulting urls do.
  • I can't create a .yml file in drive without having an extra fle extension added to it.
  • I can't create files without file extensions.

Impact

Some confusion between drive and what users would see on disk wrt what file extensions are used.

Solution

Don't automagically add file extensions when creating files in drive itself, just let the user supply the file name including file extension.

When a user creates a new file in drive, assume it is a text file with encoding utf8 and have the user add whatever file extension they want.

@icidasset
Copy link
Contributor

File extensions are shown when hovering over the directory entry, and on the detail view (sidebar when file is selected). I don't want to show all extensions by default, but I do want to make this an option later.

I agree with the extension handling when creating files 👍

I suggest the following:

  • Add a "new file" button, doesn't change filename at all
  • Hide "suggested extension" buttons when the filename already has an extension

I don't really like how these buttons fit into the whole sidebar currently, might change this up in the future.

@jeffgca
Copy link
Author

jeffgca commented May 17, 2021

I don't want to show all extensions by default, but I do want to make this an option later.

Can you unpack for me what the reasoning is here? Generally my ethic with experiences that closely follow established UI conventions is to follow all of the conventions as much as possible so as to prevent confusion.

@icidasset
Copy link
Contributor

Definitely. I'm following the MacOS convention. Don't show the file extension by default, and rely on the icon and the name to identify the file. Two differences though: (1) I think MacOS shows the file extension for unrecognised file extensions (ie. no icon) (2) We show the extension on hover.

In addition to that, I think it looks nicer, and feel that the icon + name is enough to identify the file.
But like I said, I do want to add the option later.

@icidasset
Copy link
Contributor

@therealjeffg Thoughts on the current file/dir creation? Does it solve all the problems you had with it?

@jeffgca
Copy link
Author

jeffgca commented Jun 9, 2021

@therealjeffg Thoughts on the current file/dir creation? Does it solve all the problems you had with it?

Sorry, I neglected to get back to this issue.

My opinion, perhaps put more simply: while it may be confusing to some people if we don't show the full name of the file for known file types, it will never be confusing to them if we do show the full name of the file.

Disclaimer: I am biased here, I am used to looking at file systems in a terminal and always enable "show file extensions" preferences on any computer I use.

@icidasset
Copy link
Contributor

Sounds reasonable 👍 I'll make it a setting.

@jeffgca
Copy link
Author

jeffgca commented Jun 9, 2021

Sounds reasonable 👍 I'll make it a setting.

Questions:

  1. does drive have other settings? I don't think this should be the only setting
  2. for the user, the least surprising thing to do here is to always show file extensions by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants