Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a 'Trash' concept #130

Open
jeffgca opened this issue May 10, 2021 · 4 comments
Open

Implement a 'Trash' concept #130

jeffgca opened this issue May 10, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@jeffgca
Copy link

jeffgca commented May 10, 2021

Summary

File managers usually have a 'trash' concept - so should we.

Problem

Drive will happily remove files with no confirmation dialog and then offer no way to recover in the case that this was an accident - we could mitigate this by implementing a "trash" folder in drive which is where all files go that the user wants to get out of their way.

Impact

Users might assume that removing files from Drive has some of the UI safe-guards in place like confirmation prompts and a trash can / recycling bin, and might be surprised to learn that the file they removed really is gone for good.

Solution

We should provide a trash-can / recycling style folder in the root of Drive that is where all files go to when they are removed. We should also use the same terminology eg

  1. trashcan -> send to trash
  2. recycling bin -> recycle
  3. hellmouth -> banish
@expede
Copy link
Member

expede commented May 10, 2021

Super interesting. This would be extremely lightweight, since we have all of the files in history already, so just pointers. We can think of this as "recently removed" (whiiiiich is... a trash, so yeah 😛)

@expede expede added the enhancement New feature or request label May 10, 2021
@expede
Copy link
Member

expede commented May 10, 2021

Also worth noting that this is probably a WebNative feature directly, but leaving here for now because it largely powers the Drive UI

@jeffgca
Copy link
Author

jeffgca commented May 10, 2021

Also worth noting that this is probably a WebNative feature directly, but leaving here for now because it largely powers the Drive UI

My strategy has always been - log the bug against the thing I'm looking at as my assumptions about the thing underneath that powers it can be quite misguided.

@expede
Copy link
Member

expede commented May 11, 2021

@therealjeffg Yup, you did the right thing! Agreed on working outside-in; just wanted to flag it for posterity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants