Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Make this a combined Express and React deployment #10

Open
bmann opened this issue Dec 9, 2019 · 2 comments
Open

Make this a combined Express and React deployment #10

bmann opened this issue Dec 9, 2019 · 2 comments
Assignees

Comments

@bmann
Copy link
Member

bmann commented Dec 9, 2019

By default, just the basic react app start script will bind to localhost. You can pass in a HOST variable in calling it of 0.0.0.0

Because of how Chromebook's have Ubuntu containers setup, I had a similar thing :) Need to look at port settings a bit deeper.

BUT -- the actual outcome here should be to move this to running Express, then we can build the other server endpoints I have in mind with Express, all in the same app.

Here's an article about that https://originmaster.com/running-create-react-app-and-express-crae-on-heroku-c39a39fe7851

@bmann
Copy link
Member Author

bmann commented Dec 10, 2019

OK, had to do HOST=0.0.0.0 as part of the start script so it can bind to the correct port on Heroku.

This is not ideal at all, we should run this with Express, changing this issue to reflect that that should be the outcome of this :)

@bmann bmann self-assigned this Dec 10, 2019
@bmann bmann changed the title Change deploy settings to work with Heroku Make this a combined Express and React deployment Dec 10, 2019
@bmann
Copy link
Member Author

bmann commented Dec 10, 2019

Other part that needs to be done is have secrets as Heroku vars and expose them to React. Will also have some “non secret” vars to have as examples — although that would pretty much only be available locally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant