-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default AES algorithm should be GCM #39
Comments
We could fix this now that #58 landed |
👍 And bump version to 1.0? |
I have some ideas for a "release" 1.0. E.g. I want the store to be abstracted, so that you can use keystore-idb (which at that point will be confusingly named) in nodejs. Also, I think we can greatly reduce the API surface, because I don't think we're actually using the symmetric key store from keystore-idb anywhere. We're only using the AES helper methods (encryptBytes/decryptBytes). Not a high priority right now though. |
That'd be cool yeah. Where is that symmetric key store? But, it looks like we're using everything that's in |
Ah, I'm actually wrong. I was talking about this: But we're actually using the keystore for symmetric keys: We're mainly using Anyway, I still think a good abstraction over localforage in keystore-idb would be great. Probably best to copy the one from webnative into here, and use it from webnative. If we have that, there's no reason for the dependency injection stuff we have in webnative (keystore-idb would work in nodejs with an appropriate localforage implementation). |
Replace current default algorithm AES-CTR with AES-GCM.
The text was updated successfully, but these errors were encountered: