Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc issue: Packaging source code #217

Open
hklang10 opened this issue Dec 28, 2022 · 2 comments
Open

Doc issue: Packaging source code #217

hklang10 opened this issue Dec 28, 2022 · 2 comments

Comments

@hklang10
Copy link

example env create contains --poolsize argument but not --version, so poolsize is ignored.

fission env create --name pythonsrc --image fission/python-env:latest \
                     --builder fission/python-builder:latest \
                     --mincpu 40 --maxcpu 80 \
                     --minmemory 64 --maxmemory 128 \
                     --poolsize 2

should read:

                     --poolsize 2 --version 3
@hklang10 hklang10 changed the title Packaging source code Doc issue: Packaging source code Dec 28, 2022
@hklang10
Copy link
Author

same issue is also in https://fission.io/docs/usage/function/functions/

@hklang10
Copy link
Author

the CLI doc says the default is 1 however fission env create (in V1.17) does seem to set the version inconsistently
(seems to be dependent on language, and if --builder is used.)

For consistency, the docs might be better to explicitly set --version when using --poolsize.

Will push some PRs to make this consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants