Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify old version in PR title #311

Closed
rany2 opened this issue Jun 24, 2022 · 2 comments
Closed

Specify old version in PR title #311

rany2 opened this issue Jun 24, 2022 · 2 comments

Comments

@rany2
Copy link
Contributor

rany2 commented Jun 24, 2022

I've noticed that FEDC sometimes creates PRs that downgrade the package (probably from a caching issue on the mirror's end). In this issue I'm proposing that the PR title/body be modified to specify the old version and the new version it's getting bumped to.

Example:

  • Update chromium-101.0.4951.54.tar.xz from 101.0.4951.54 to 101.0.4951.64
@rany2 rany2 changed the title Modify PR title and body (if multiple modules updated) Specify old version in PR title Jun 24, 2022
@rany2
Copy link
Contributor Author

rany2 commented Jun 24, 2022

This issue happens mostly in the Brave flatpak though, I think it might be better to add a check to make sure that the PR is upgrading and not downgrading instead.

@gasinvein
Copy link
Collaborator

gasinvein commented Jun 24, 2022

The problem is, f-e-d-c doesn't know what the current version is - there is no such information stored in the manifest currently.
Kinda duplicate of #286, I'll rename and pin that one as a more generic issue.

@gasinvein gasinvein closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants