Fleetctl denylist: false option does not work

[ar-mi]

What version of fleet are you using (fleet version --full)?

fleet - version 3.5.1
branch: master
revision: 55a2aa2
build date: 2020-12-15T02:50:05Z
build user: zwass
go version: go1.15

What operating system are you using?

NAME="CentOS Linux"
VERSION="8"

If this is a UI issue: What browser are you using?

No, this is a problem with the "fleetct" console utility

If this is a performance issue: Please attach the debug archive.

No, this is a problem with the "fleetctl" console utility

What did you do?

1. I’ve logged in Fleet using fleetctl, got target pack and redirected it to file using fleetctl get pack test_pack > pack.yml

2. Then I manually added denylist: false option after version option, renaimed this pack and did fleetctl apply -f pack.yml

3. But when I do fleetctl get pack test_pack2 again, I don’t see denylist: false option.

4. I tested the request itself after the performed actions (of course, on another more complex request) and I can say that denilist: false really does not work, requests on some clients continue to fall into denylist.

What did you expect to see?

Correct work of the denylist option as noted at #195

What did you see instead?

Option does not work

[noahtalerman]

I've confirmed the observed behavior explained in this issue by @ar-mi in Fleet 3.6.0. Setting the denylist property and then applying via fleetctl doesn't add the property to the pack's configuration.

[noahtalerman]

The request for denylist was made in a recent issue in the archived kolide/fleet repo: kolide/fleet#2335

[zwass]

@ar-mi my apologies that I suggested in #195 that this works. We'll have the fix/addition in the 3.7.0 release.