Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chosen colors not consistent between iOS and Mac OS X versions #7

Open
blabus opened this issue May 24, 2013 · 3 comments
Open

Chosen colors not consistent between iOS and Mac OS X versions #7

blabus opened this issue May 24, 2013 · 3 comments

Comments

@blabus
Copy link

blabus commented May 24, 2013

I noticed that when running both this version of the project and the Mac OS X version, and selecting the exact same image file, that the chosen colors are not the same, and in many cases substantially different (entirely different hues). Any ideas why this might be? And if it would be possible to make it more closely resemble the results of the original Mac OS X version from Panic?

@fleitz
Copy link
Owner

fleitz commented May 25, 2013

Older versions should be more consistent with the original project. I know the algorithm has had many performance optimizations made to it.

I'd be happy to apply a pull request that made it more consistent with Panic's code.

@blabus
Copy link
Author

blabus commented May 25, 2013

@fleitz That would be excellent. Yeah the performance is great, but I noticed that the original Panic version seems to be a bit more accurate with the color choices, particularly the background color.

Thanks!

@tromg
Copy link

tromg commented Jun 5, 2013

@blabus try to open "SLColorArt.m" and set NSUInteger pixelRange = 32;
background will be much better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants