Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mnemonic confirmation UX #14

Open
daniel-flex opened this issue Oct 28, 2020 · 6 comments
Open

Mnemonic confirmation UX #14

daniel-flex opened this issue Oct 28, 2020 · 6 comments
Labels
sigp Input from Sigma Prime is required to resolve

Comments

@daniel-flex
Copy link
Collaborator

Regarding the process for Mnemonic confirmation, after internal discussions have mostly agreed upon this from aqeel:

With sufficient context provided, forcing a check is required to provide enough friction for users to actually grasp that it's important. I would say the subset should be 6-12 leaning towards 12 and perhaps from a particular area so it is less cumbersome.

The way I had it designed originally was it picks from the 4 sub-sections so it picks two rows from 1-6, 7-12, 13-18, 19-24. For you to fill out.

And you can provide a disclaimer that we are putting the check in for demonstration purposes but still their responsbility and dont take any onus of confirming the validity for all 24 words.
putting in 12 random numbers is more difficult that it is just to enter 24 in a row. So having some sort of order helps negate that.

There's also some discussion around putting different options behind a build flag, so devs/QA can skip the process if need be.

@daniel-flex daniel-flex added flex Input from Flex Dapps is required to resolve empire Input from Empire is required to resolve labels Oct 28, 2020
@daniel-flex
Copy link
Collaborator Author

daniel-flex commented Oct 31, 2020

moving forward with this today @paulhauner. For clarification, as discussed with @qnou, will do the following:

  1. user will need to confirm 1 row (6 words) from rows 1 & 2, and 1 row from rows 4 & 5.
  2. confirmation screen will show all 24 slots, with some rows disabled, and some empty, ready for user input (see below)

so confirmation interface will look like:

[****][****][****][****][****][****]
[____][____][____][____][____][____]
[____][____][____][____][____][____]
[****][****][****][****][****][****]

Also, will we always force confirmation of the last word, to ensure the user has 24 words written down? (waiting on confirmation from @qnou for this)

I'll also put an evn flag in place for developers to display a 'skip' button on the confirmation page - for testing.

@daniel-flex
Copy link
Collaborator Author

daniel-flex commented Nov 1, 2020

pushed mnemonic confirmation type update: dde4c28
pushed skip button on 8f098db

also, new env flag for mnemonic confirmation type:
REACT_APP_MNEMONIC_CONFIRMATION_TYPE=ALL
options: ALL|TWOROWS

@qnou @paulhauner test and confirm

@daniel-flex daniel-flex added sigp Input from Sigma Prime is required to resolve and removed flex Input from Flex Dapps is required to resolve labels Nov 1, 2020
@paulhauner
Copy link
Collaborator

Tested on my end, skip button is working and so is two-row confirmation.

Something to note is that if you confirm the mnemonic, then go back you can get a different two rows to confirm. Not a deal breaker, but might be nice to avoid if the fix is simple.

@paulhauner paulhauner added flex Input from Flex Dapps is required to resolve and removed sigp Input from Sigma Prime is required to resolve labels Nov 1, 2020
@daniel-flex
Copy link
Collaborator Author

@paulhauner will set a confirmed flag and and bypass if already confirmed

@qnou
Copy link

qnou commented Nov 4, 2020

@daniel-flex anything left remaining on this from my end?

@daniel-flex daniel-flex removed the empire Input from Empire is required to resolve label Nov 4, 2020
@daniel-flex
Copy link
Collaborator Author

@paulhauner added in #2f65f9d

@daniel-flex daniel-flex added sigp Input from Sigma Prime is required to resolve and removed flex Input from Flex Dapps is required to resolve labels Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sigp Input from Sigma Prime is required to resolve
Projects
None yet
Development

No branches or pull requests

3 participants