Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX around connection fields for BN and VC #8

Open
paulhauner opened this issue Oct 27, 2020 · 12 comments
Open

UI/UX around connection fields for BN and VC #8

paulhauner opened this issue Oct 27, 2020 · 12 comments
Assignees
Labels
empire Input from Empire is required to resolve flex Input from Flex Dapps is required to resolve RFC Request for comments sigp Input from Sigma Prime is required to resolve

Comments

@paulhauner
Copy link
Collaborator

On the "configure connection" page, a couple of our team got stuck without realising that http:// is required. It might be nice to hint to the user that you need that prefix.

Here's some suggestions from me:

  • Prefill the address field with http://localhost.
  • Add a little bit of text to say that http/https prefix is required
  • Show a specific error if they omit this part (we'd probably have to pattern match *://* or something, so we don't artificially limit protocols)
@paulhauner paulhauner added the flex Input from Flex Dapps is required to resolve label Oct 27, 2020
@daniel-flex
Copy link
Collaborator

daniel-flex commented Oct 27, 2020

@paulhauner there's a regex pattern match in there already, but might have to tweak it.

Also if we're going to revise the host part of the connection form to be more verbose or provide more control (#7), then I think it's natural that this update fits in there somewhere.

@paulhauner
Copy link
Collaborator Author

there's a regex pattern match in there already, but might have to tweak it.

Is this the warning that appears on the right? If so, can we move that over to the left, underneath the text input?

@AgeManning
Copy link

Perhaps if a protocol isn't submitted we default to http?

@daniel-flex
Copy link
Collaborator

I think we run this through UI/UX again with the new requirements and see what can be done. We can probably solve it here but I think design will have some better ideas.

considerations (feel free to update):

  1. we need all parts independently configurable (protocol, ip/domain, port), with validation, for both BN and VC
  2. do we want to have 6 editable fields on screen just for what the user may perceive as a single endpoint (might be too complicated)
  3. do we hide most of it (how much of it?) behind a easy-to-digest 'summary' with the ability to open and configure?

Also considering when a user returns, they don't want to have to deal with it again, it should have everything saved and they just hit the connect button.

Could even consider having more options: save my data (which is does currently by default - in localstorage), and auto-connect, so it just connects them straight into the dahsboard.

@daniel-flex daniel-flex added the empire Input from Empire is required to resolve label Oct 30, 2020
@daniel-flex
Copy link
Collaborator

daniel-flex commented Oct 30, 2020

fyi current designs
Screen Shot 2020-10-31 at 9 41 44 am

@qnou
Copy link

qnou commented Oct 31, 2020

Is it only the http/s protocol for connection? If so, it should be prefilled automatically and shown persistently, only the address afterwards should therefore be editable. If it is not the only protocol and we need to leave room for others, then as @AgeManning mentioned we should also have a default fallback to http. Will address #7 accordingly.

@daniel-flex
Copy link
Collaborator

daniel-flex commented Oct 31, 2020

@qnou for both the BN and VC endpoints, the user needs to be able to independently configure:

  1. protocol: options will be http or https (I believe that's all)
  2. ip/domain: either an ip address (127.0.0.1) or a domain name (mydomain.io)
  3. port: 4-5 digit configurable port number (eg: 5689)

So it needs to be:

BN: [protocol][ip][port]
VC: [protocol][ip][port]

For point 1 (protocol), we could have it hardcoded with a checkbox for 'secure connection', which changes from http to https, but will still need it for both the BN and VC, and not sure if that's familiar UI/UX.

But in saying that, a single input field for each where the user enters everything in a single string, ie https://127.0.0.1:5052, would work too

@qnou
Copy link

qnou commented Oct 31, 2020

Points 123 understood.
The reason the port and address were separated was based on the understanding the addresses would usually be the same.

That being said, need some context on: how common would it be for the BN and VC address to be different. so can adjust accordingly whether (progressive disclosure) or core part of UI.

@daniel-flex daniel-flex added the sigp Input from Sigma Prime is required to resolve label Oct 31, 2020
@daniel-flex
Copy link
Collaborator

daniel-flex commented Oct 31, 2020

@qnou

how common would it be for the BN and VC address to be different

I'd presume they'd be more often than not on the same machine, but they could also have completely different domains/subdomains associated with them, meaning even if they're on the same machine the address could be completely different.

This would need some input/clarification from @paulhauner I think

@daniel-flex
Copy link
Collaborator

daniel-flex commented Oct 31, 2020

have merged #7 into this, as it's in the same problem space

@daniel-flex daniel-flex changed the title Provide a hint that http/https prefix is required UI/UX around connection fields for BN and VC Oct 31, 2020
@paulhauner
Copy link
Collaborator Author

I'm not really sure how often the BN/VC will be on the same host, but my gut feeling is that we should default to the same host (as we have now) with an "advanced" option to add a custom URL for each.

I'm not opposed to having 6 fields on the advanced page, as long as they have sensible default values.

Having a drop-down with http (default) or https seems good to me.

@daniel-flex daniel-flex assigned daniel-flex and qnou and unassigned daniel-flex Nov 1, 2020
@daniel-flex
Copy link
Collaborator

daniel-flex commented Nov 7, 2020

@paulhauner @qnou have pushed these updates in e381303. I'll leave this ticket open for feedback.

@daniel-flex daniel-flex added the RFC Request for comments label Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
empire Input from Empire is required to resolve flex Input from Flex Dapps is required to resolve RFC Request for comments sigp Input from Sigma Prime is required to resolve
Projects
None yet
Development

No branches or pull requests

4 participants