-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/UX around connection fields for BN and VC #8
Comments
@paulhauner there's a regex pattern match in there already, but might have to tweak it. Also if we're going to revise the host part of the connection form to be more verbose or provide more control (#7), then I think it's natural that this update fits in there somewhere. |
Is this the warning that appears on the right? If so, can we move that over to the left, underneath the text input? |
Perhaps if a protocol isn't submitted we default to http? |
I think we run this through UI/UX again with the new requirements and see what can be done. We can probably solve it here but I think design will have some better ideas. considerations (feel free to update):
Also considering when a user returns, they don't want to have to deal with it again, it should have everything saved and they just hit the connect button. Could even consider having more options: save my data (which is does currently by default - in localstorage), and auto-connect, so it just connects them straight into the dahsboard. |
Is it only the http/s protocol for connection? If so, it should be prefilled automatically and shown persistently, only the address afterwards should therefore be editable. If it is not the only protocol and we need to leave room for others, then as @AgeManning mentioned we should also have a default fallback to http. Will address #7 accordingly. |
@qnou for both the BN and VC endpoints, the user needs to be able to independently configure:
So it needs to be:
For point 1 (protocol), we could have it hardcoded with a checkbox for 'secure connection', which changes from http to https, but will still need it for both the BN and VC, and not sure if that's familiar UI/UX. But in saying that, a single input field for each where the user enters everything in a single string, ie https://127.0.0.1:5052, would work too |
Points 123 understood. That being said, need some context on: how common would it be for the BN and VC address to be different. so can adjust accordingly whether (progressive disclosure) or core part of UI. |
I'd presume they'd be more often than not on the same machine, but they could also have completely different domains/subdomains associated with them, meaning even if they're on the same machine the address could be completely different. This would need some input/clarification from @paulhauner I think |
have merged #7 into this, as it's in the same problem space |
I'm not really sure how often the BN/VC will be on the same host, but my gut feeling is that we should default to the same host (as we have now) with an "advanced" option to add a custom URL for each. I'm not opposed to having 6 fields on the advanced page, as long as they have sensible default values. Having a drop-down with http (default) or https seems good to me. |
@paulhauner @qnou have pushed these updates in e381303. I'll leave this ticket open for feedback. |
On the "configure connection" page, a couple of our team got stuck without realising that
http://
is required. It might be nice to hint to the user that you need that prefix.Here's some suggestions from me:
http://localhost
.*://*
or something, so we don't artificially limit protocols)The text was updated successfully, but these errors were encountered: