Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make undo history a delegate #101

Open
fluffy-critter opened this issue Nov 2, 2023 · 0 comments
Open

Make undo history a delegate #101

fluffy-critter opened this issue Nov 2, 2023 · 0 comments
Labels
code quality paying down technical debt

Comments

@fluffy-critter
Copy link
Owner

Per the work on #100 it's become clear that Qt really wants its object ownership hierarchy to be its own thing, rather than maintaining parallel references in both Python and C++-land.

AlbumEditor's undo history is currently done as a parallel reference in that way, and needs to be turned into a delegate, which should be pretty straightforward, at least.

This would likely be done by creating an AlbumDataDelegate class which contains AlbumEditor's data, undo_history, and redo_history members, and the record_undo method.

@fluffy-critter fluffy-critter added the code quality paying down technical debt label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality paying down technical debt
Projects
None yet
Development

No branches or pull requests

1 participant