Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

job-manager: don't use flux imp kill to signal housekeeping, perilog #6409

Closed
garlick opened this issue Nov 1, 2024 · 0 comments
Closed

job-manager: don't use flux imp kill to signal housekeeping, perilog #6409

garlick opened this issue Nov 1, 2024 · 0 comments

Comments

@garlick
Copy link
Member

garlick commented Nov 1, 2024

Problem: flux imp kill will be deprecated but the job manager uses it to terminate housekeeping and prolog/epilog tasks.

Just use regular subprocess_kill() and the IMP should forward signals.

First we need flux-framework/flux-security#188 though.
garlick added a commit to garlick/flux-core that referenced this issue Nov 1, 2024
@garlick
job-manager: use subprocess kill not flux imp kill
980229f 
Problem: housekeeping and perilog use 'flux imp kill' to implement
send signals to housekeeping and prolog/epilog processes, but
the 'flux imp kill' subcommand is being deprecated in favor of having
the IMP forwarding signals.

Don't configure bulk-exec with the imp path so that bulk_exec_kill()
will use flux_subprocess_kill().

Fixes flux-framework#6409
This was referenced Nov 1, 2024
Closed
Merged
garlick added a commit to garlick/flux-core that referenced this issue Nov 4, 2024
@garlick
job-manager: don't use flux imp kill
43312e3 
Problem: housekeeping and perilog use 'flux imp kill' to send
signals to housekeeping and prolog/epilog processes, but the
IMP will now forward signals and 'flux imp kill' is deprecated.

Don't call bulk_exec_set_imp_path() in housekeeping and perilog.

Fixes flux-framework#6409
garlick added a commit to garlick/flux-core that referenced this issue Nov 4, 2024
@garlick
job-manager: don't use flux imp kill
9253d26 
Problem: housekeeping and perilog use 'flux imp kill' to send
signals to housekeeping and prolog/epilog processes, but the
IMP will now forward signals and 'flux imp kill' is deprecated.

Don't call bulk_exec_set_imp_path() in housekeeping and perilog.

Fixes flux-framework#6409
garlick added a commit to garlick/flux-core that referenced this issue Nov 4, 2024
@garlick
job-manager: don't use flux imp kill
e98d042 
Problem: housekeeping and perilog use 'flux imp kill' to send
signals to housekeeping and prolog/epilog processes, but the
IMP will now forward signals and 'flux imp kill' is deprecated.

Don't call bulk_exec_set_imp_path() in housekeeping and perilog.

Fixes flux-framework#6409
garlick added a commit to garlick/flux-core that referenced this issue Nov 6, 2024
@garlick
job-manager: don't use flux imp kill
7f65667 
Problem: housekeeping and perilog use 'flux imp kill' to send
signals to housekeeping and prolog/epilog processes, but the
IMP will now forward signals and 'flux imp kill' is deprecated.

Don't call bulk_exec_set_imp_path() in housekeeping and perilog.

Fixes flux-framework#6409
@mergify mergify bot closed this as completed in 9fdfebe Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP job-manager: use subprocess kill not flux imp kill garlick/flux-core
1 participant
@garlick