Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore NFD Properties #75

Open
vsoch opened this issue May 28, 2024 · 1 comment
Open

Restore NFD Properties #75

vsoch opened this issue May 28, 2024 · 1 comment

Comments

@vsoch
Copy link
Member

vsoch commented May 28, 2024

I don't think we are using NFD Properties (and there has been considerable work on them in the last few years) so I think what might make sense to do now is to remove them from our parsing, and add back strategically for specific things that we want/need. I think with the changes to NFD, if we leave them now if someone is using NFD we could hit a bug or it wouldn't do anything, and I want to make sure we are adding metadata / nodes knowing what the outcome / scenarios should be.

It looks like our graph doesn't have sockets or racks either - so removing those until we need them too.

@vsoch
Copy link
Member Author

vsoch commented Oct 31, 2024

Related: #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant