Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird diagnostic formatting when highlight ends in two line breaks #133

Open
fmease opened this issue Mar 2, 2022 · 0 comments
Open

Weird diagnostic formatting when highlight ends in two line breaks #133

fmease opened this issue Mar 2, 2022 · 0 comments
Labels
A-diagnostics Area: Diagnostics T-bug Type: Something isn't working as intended

Comments

@fmease
Copy link
Owner

fmease commented Mar 2, 2022

Example (a metadata file):

# TEST fail check


Example diagnostic:

error[E802]: the map is missing the key `name`
 --> /home/fmease/programming/main_projects/lushui/test/ui/tests/packages/empty-manifest/package.metadata:1:1
  |
1 |   # TEST fail check
  |  _^
2 | |
  | |^
  |

See the |^ at the end? Looks weird and should (probably be a |_^) since currently the ^ points “outside” of the document (see how the #, the start of the file, is one column further to the right).

@fmease fmease added T-bug Type: Something isn't working as intended A-diagnostics Area: Diagnostics labels Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnostics T-bug Type: Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

1 participant