You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Thanks for providing this library. I am reviewing Desk API client libraries for potential inclusion in an internal project. I was not able to complete my review of this library because:
While reviewing this one I note that it is not designed to work with Mac. When I look through the code the only class that seems like it is problematic is this one: DSAPINetworkIndicatorController.h
I think you should trying to not depend on UIKit and instead of Foundation only if possible like you did in the rest of the project. From my read of this class it seems it would be straight forward to support both OSX and iOS using #if def for this one file.
Is there a reason that I am not seeing that this project only supports iOS?
The text was updated successfully, but these errors were encountered:
Hi @yepher, the original intent was to only support iOS. You're absolutely right though, this could be easily made to run on macOS also. This is the first request we've had to support macOS. I'll pass it along to our Product Manager. I can't make any guesses when we would work on it.
If you feel adventurous, you can clone it down and if you get it to work in a macOS project, issue a PR against the develop branch and we'll happily review/merge your changes.
Thanks for providing this library. I am reviewing Desk API client libraries for potential inclusion in an internal project. I was not able to complete my review of this library because:
While reviewing this one I note that it is not designed to work with Mac. When I look through the code the only class that seems like it is problematic is this one: DSAPINetworkIndicatorController.h
I think you should trying to not depend on
UIKit
and instead of Foundation only if possible like you did in the rest of the project. From my read of this class it seems it would be straight forward to support both OSX and iOS using#if def
for this one file.Is there a reason that I am not seeing that this project only supports iOS?
The text was updated successfully, but these errors were encountered: