Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better guarantees and documentation for events #247

Open
breezykermo opened this issue Apr 9, 2022 · 0 comments
Open

Better guarantees and documentation for events #247

breezykermo opened this issue Apr 9, 2022 · 0 comments

Comments

@breezykermo
Copy link
Member

breezykermo commented Apr 9, 2022

Because event IDs exist in sheet-like data sources outside of timemap, and the appropriate API endpoints for timemap to consume are usually created by datasheet-server, there is no way in timemap itself to enforce the requirement that event IDs are consistent between data updates. See this issue thread for greater context. This should be made clearer in the documentation.

There can and should, however, be validation of event data to ensure that IDs are unique. This should be done in validators.js, appropriately dropping any events with duplicate IDs (as we currently do with filters). It's possible that timemap behaves reasonably when there are events with the same ID, but this is not a case that I can imagine a use case for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant