Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Failing #1050

Open
YashKumarVerma opened this issue Oct 6, 2019 · 4 comments · May be fixed by #1069
Open

Build Failing #1050

YashKumarVerma opened this issue Oct 6, 2019 · 4 comments · May be fixed by #1069

Comments

@YashKumarVerma
Copy link
Member

Expected Behavior

Game build should deploy the game on every new commit

Current Behavior

because of some images in the game, the build is failing.

Possible Solution

the proper solution to this is to resize the images, however, by the time it is pending, the image checking module can be skipped.
@samyakbvs
Copy link
Contributor

I will take this up

@samyakbvs
Copy link
Contributor

What should be the size of every image in the game?

@YashKumarVerma
Copy link
Member Author

What should be the size of every image in the game?

https://github.com/fossasia/labyrinth/blob/master/img_config.yml

@samyakbvs
Copy link
Contributor

I will start working on this as soon as #1066 is merged

This was referenced Dec 5, 2019
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resized
Size test
2 participants
@YashKumarVerma @samyakbvs