Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove credentials from scripts #929

Open
iamareebjamal opened this issue Nov 26, 2018 · 3 comments
Open

Remove credentials from scripts #929

iamareebjamal opened this issue Nov 26, 2018 · 3 comments
Labels
enhancement quality improves the quality of the project

Comments

@iamareebjamal
Copy link
Member

Travis CI scripts contain surge credentials which anyone can use to deploy the site. This should never have been commited and should be changed to environment variables in CI

@YashKumarVerma
Copy link
Member

If they are changed to environment variables, the pull requests won't get it working because the contributers won't have the credentials in their travis.

Possible solution is to encrypt them using travis Ruby gem

@iamareebjamal
Copy link
Member Author

No one can change the environment variables except admins and maintainers. Encrypting using Travis gem is also using secrets as environment variables which are used to decrypt the file. Secondly, encrypting is used for files which can't be used as environment variables.

@abishekvashok
Copy link
Member

If they are changed to environment variables, the pull requests won't get it working

@YashKumarVerma YashKumarVerma added enhancement quality improves the quality of the project labels Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement quality improves the quality of the project
Projects
None yet
Development

No branches or pull requests

3 participants