Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vllm in-process handles sampling temperature incorrectly #194

Open
jlquinn opened this issue Jan 16, 2025 · 0 comments
Open

vllm in-process handles sampling temperature incorrectly #194

jlquinn opened this issue Jan 16, 2025 · 0 comments

Comments

@jlquinn
Copy link

jlquinn commented Jan 16, 2025

Describe the bug

When using decoding method "sample", the temperature is not handled correctly.

  1. The default temperature is 0.0, instead of 1.0.
  2. If the user sets a temperature, the default of 0.0 will override the user value.

Platform

Please provide details about the environment you are using, including the following:

  • Interpreter version: 3.12.7
  • Library version: 4151c97

The bug is at vllm_in_proc.py:461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlquinn