Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp sncast cli #2552

Closed
3 tasks
cptartur opened this issue Oct 3, 2024 · 1 comment
Closed
3 tasks

Revamp sncast cli #2552

cptartur opened this issue Oct 3, 2024 · 1 comment
Assignees
Labels
feature New feature request/description sncast
Milestone

Comments

@cptartur
Copy link
Member

cptartur commented Oct 3, 2024

As part of this issue, let's design and implement changes to sncast cli.

  • Remove global arguments that are not in fact global (e.g. --account can always be passed but is not handled by sncast account methods)
  • Consider improving the validation of optional arguments (i.e. some of them are mutually exclusive or should be provided at the same time, it is likely this can be resolved on clap level)

This should be implemented in a non-breaking manner: changes should be proposed through design-doc, then we should deprecate anything that can be deprecated and in future versions we should introduce our changes. This will likely result in some conflicting arguments initially, but it less likely to break users' scripts etc.

After release that introduce warnings:

  • Restore tests to the previous version, they are marked as TODO(#2552)
@cptartur cptartur converted this from a draft issue Oct 3, 2024
@github-actions github-actions bot added the new label Oct 3, 2024
@cptartur cptartur added sncast feature New feature request/description design-doc and removed new labels Oct 3, 2024
@integraledelebesgue integraledelebesgue added this to the Cast refactor milestone Oct 3, 2024
@cptartur cptartur closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Starknet foundry Nov 4, 2024
@cptartur cptartur reopened this Nov 4, 2024
@github-project-automation github-project-automation bot moved this from Done to New in Starknet foundry Nov 4, 2024
@cptartur
Copy link
Member Author

Closing in favor of #2603

@cptartur cptartur closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in Starknet foundry Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request/description sncast
Projects
Archived in project
Development

No branches or pull requests

3 participants