Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check internal packages formatting #2596

Closed
franciszekjob opened this issue Oct 21, 2024 · 1 comment
Closed

Check internal packages formatting #2596

franciszekjob opened this issue Oct 21, 2024 · 1 comment
Labels
maintenance new

Comments

@franciszekjob
Copy link
Collaborator

Which components does the task require to be changed? (think hard pls)

other (describe below)

Description

We have many internal packages (needed mostly for testing purposes, located in crates/forge/tests/data) and their formatting isn't checked. We could add step in CI which runs scarb --fmt.
@Benjtalkshow
Copy link

Benjtalkshow commented Oct 21, 2024 •
edited
Loading

hello @franciszekjob
Is this issue open for contribution? i would love to work on this issue. i use rust and i am confident i can fix this issue.
I will carefully configure the CI pipeline and ensure the packages in crates/forge/tests/data are properly formatted. Thanks

@franciszekjob franciszekjob removed the good first issue Good for newcomers label Oct 21, 2024
@github-project-automation github-project-automation bot moved this from New to Done in Starknet foundry Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance new
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@franciszekjob @Benjtalkshow