Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contracts Collection docs #2627

Closed
cptartur opened this issue Oct 30, 2024 · 0 comments · Fixed by #2656
Closed

Update Contracts Collection docs #2627

cptartur opened this issue Oct 30, 2024 · 0 comments · Fixed by #2656
Assignees
Labels
documentation Improvements or additions to documentation snforge

Comments

@cptartur
Copy link
Member

cptartur commented Oct 30, 2024

With optimized contracts and tests compilation behavior of contracs collection is different than this outlined in Contracts collection docs.

Update the documentation so that it is up to date.

@cptartur cptartur converted this from a draft issue Oct 30, 2024
@github-actions github-actions bot added the new label Oct 30, 2024
@cptartur cptartur changed the title Update contracts collection docs Update Contracts Collection docs Oct 30, 2024
@cptartur cptartur added documentation Improvements or additions to documentation snforge labels Oct 30, 2024
@cptartur cptartur removed the new label Nov 4, 2024
@cptartur cptartur moved this from Backlog to TODO in Starknet foundry Nov 4, 2024
@cptartur cptartur self-assigned this Nov 4, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 19, 2024
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2627
Closes #2465

## Introduced changes

<!-- A brief description of the changes -->

- Split contract collection docs into two parts: one showing new
mechanism and one showing old
- Moved current (old) contract collection docs to subpage
- Added new contract collection docs subpage
- Added information that Scarb handles test collection and linked
relevant sections in Scarb docs
- Reworked test collection docs

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Franciszek Job <54181625+franciszekjob@users.noreply.github.com>
Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation snforge
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant