Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if all dependencies are installed in correct version in runtime #2720

Closed
cptartur opened this issue Nov 27, 2024 · 0 comments · Fixed by #2752
Closed

Check if all dependencies are installed in correct version in runtime #2720

cptartur opened this issue Nov 27, 2024 · 0 comments · Fixed by #2752
Assignees
@cptartur
Labels
feature New feature request/description snforge

Comments

@cptartur
Copy link
Member

To run snforge, it is required to have rust installed in a correct version. This is so plugins can be built.

Add a runtime check that verifies the compatibility of snforge with dependencies installed in the system.
The check should be run before any snforge command.

$ snforge compatibility-check

rust > x.y.z ❌ Install scarb using ...
Scarb > x.y.z ✅

The output should always be shown when running snforge compatibility-check
If running any other commands, only show the ouput if any compatibility check failed. If all passed, do not show the output.
@cptartur cptartur added feature New feature request/description snforge labels Nov 27, 2024
@cptartur cptartur moved this to New in Starknet foundry Nov 27, 2024
@github-actions github-actions bot added the new label Nov 27, 2024
@cptartur cptartur mentioned this issue Nov 27, 2024
Closed
@cptartur cptartur removed the new label Nov 27, 2024
@cptartur cptartur moved this from New to TODO in Starknet foundry Nov 27, 2024
@cptartur cptartur self-assigned this Nov 27, 2024
@cptartur cptartur moved this from TODO to In Progress in Starknet foundry Nov 27, 2024
@cptartur cptartur mentioned this issue Dec 4, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 10, 2024
@cptartur
Validate dependencies in runtime (#2752)
96d4204 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2720
Closes #2719

## Introduced changes

<!-- A brief description of the changes -->

- Added requirements validation as a mandatory step before any `snforge`
command. The output is only shown if validation fails
- Added new subcommand `snforge check-requirements` that always displays
validation output.

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cptartur cptartur

Labels
feature New feature request/description snforge
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate dependencies in runtime foundry-rs/starknet-foundry
1 participant
@cptartur