Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve snforge_std api #2808

Open
kkawula opened this issue Dec 20, 2024 · 6 comments · May be fixed by #2885
Open

Improve snforge_std api #2808

kkawula opened this issue Dec 20, 2024 · 6 comments · May be fixed by #2885
Assignees
Labels
feature New feature request/description odboost: Easy ODBoost snforge

Comments

@kkawula
Copy link
Collaborator

kkawula commented Dec 20, 2024

Which components does the task require to be changed? (think hard pls)

snforge

Description

https://github.com/foundry-rs/starknet-foundry/blob/master/snforge_std/src/_config_types.cairo packaged should be quasi private i.e. reexported by _internals

As shown here:

pub mod _config_types;

TODO:

  • Move _config_types package to be reexported by _internals
  • Update tests that use the _config_types (should be easily searchable in repo)
@cptartur
Copy link
Member

@kkawula please update the issue description

@cptartur cptartur added snforge feature New feature request/description and removed new labels Jan 17, 2025
@cptartur cptartur moved this from New to Triage in Starknet foundry Jan 17, 2025
@cptartur cptartur moved this from Triage to Backlog in Starknet foundry Jan 17, 2025
@danielrobotz
Copy link

May I try my hand at this?

@raizo07
Copy link

raizo07 commented Jan 22, 2025

Is it okay if I tackle this?

@khayss
Copy link
Contributor

khayss commented Jan 22, 2025

Would love to tackle this!

@kkawula
Copy link
Collaborator Author

kkawula commented Jan 26, 2025

Hi @danielrobotz, any progress on this?

@danielrobotz
Copy link

yes, will create a pr soon

danielrobotz added a commit to danielrobotz/starknet-foundry that referenced this issue Jan 27, 2025
@danielrobotz danielrobotz linked a pull request Jan 27, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request/description odboost: Easy ODBoost snforge
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

5 participants