Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add edition fields to snforge lib #2819

Closed
enitrat opened this issue Dec 23, 2024 · 2 comments
Closed

add edition fields to snforge lib #2819

enitrat opened this issue Dec 23, 2024 · 2 comments
Labels

Comments

@enitrat
Copy link
Contributor

enitrat commented Dec 23, 2024

Which components does the task require to be changed? (think hard pls)

snforge

Description

Any package using starknet-foundry and snforge will have all these warnings when building which is upsetting.

Add edition fields in all packages.

image
@cptartur
Copy link
Member

cptartur commented Jan 7, 2025

@enitrat what snforge version are you using? Editions should be set everywhere since #2649

@enitrat
Copy link
Contributor Author

enitrat commented Jan 7, 2025

Looks good now, thank you. I was not able to update at that time but now it's fine

@enitrat enitrat closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Starknet foundry Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants