Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate versions other than v3 in sncast commands that accept --version #2828

Closed
cptartur opened this issue Jan 7, 2025 · 0 comments · Fixed by #2834
Closed

Deprecate versions other than v3 in sncast commands that accept --version #2828

cptartur opened this issue Jan 7, 2025 · 0 comments · Fixed by #2834
Assignees
@kkawula
Labels
feature New feature request/description sncast

Comments

@cptartur
Copy link
Member

cptartur commented Jan 7, 2025 •
edited
Loading

Show deprecation warnings in case someone uses other version of transaction than v3. For all kinds of transactions.

In case someone uses --version v3 show deprecation warning for the whole --version flag.
@cptartur cptartur converted this from a draft issue Jan 7, 2025
@github-actions github-actions bot added the new label Jan 7, 2025
@cptartur cptartur added sncast feature New feature request/description and removed new labels Jan 7, 2025
@kkawula kkawula mentioned this issue Jan 9, 2025
Merged
5 tasks
@kkawula kkawula marked this as a duplicate of #2774 Jan 10, 2025
@cptartur cptartur moved this from TODO to In Progress in Starknet foundry Jan 14, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 14, 2025
@kkawula
Add deprecation info of version flag (#2834)
9dca1ce 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2828

## Introduced changes

<!-- A brief description of the changes -->

-

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkawula kkawula

Labels
feature New feature request/description sncast
Projects
Starknet foundry
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add deprecation info of version flag foundry-rs/starknet-foundry
2 participants
@cptartur @kkawula