Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show --max-n-steps in the error #2853

Open
cptartur opened this issue Jan 14, 2025 · 8 comments · May be fixed by #2869
Open

Show --max-n-steps in the error #2853

cptartur opened this issue Jan 14, 2025 · 8 comments · May be fixed by #2869
Assignees
@Thibrac
Labels
feature New feature request/description odboost: Easy ODBoost snforge

Comments

@cptartur
Copy link
Member

cptartur commented Jan 14, 2025 •
edited
Loading

If a test runs out of steps an Could not reach the end of the program. RunResources has no remaining steps. error is displayed.

This error comes from CairoVM, so we cannot modify it directly. However in the function that handles the test result, we can map the error message and add additional details to it.

In

starknet-foundry/crates/forge-runner/src/running.rs

Line 309 in 8ce451e

Err(error) => TestCaseSummary::Failed {
if the error is UnfinishedExecution::UnfinishedExecution, map it and add information about the ability to use --max-n-steps.

Introduce a test verifying it is displayed and/or update existing tests.

Update the error so it also shows the possibility to increase the steps with --max-n-steps.
@cptartur cptartur added feature New feature request/description snforge labels Jan 14, 2025
@cptartur cptartur moved this to New in Starknet foundry Jan 14, 2025
@github-actions github-actions bot added the new label Jan 14, 2025
@emarc99
Copy link

emarc99 commented Jan 16, 2025

I'll love to do this. Have experience with rust through recent contribution to Dojo Engine.

@cptartur cptartur removed the new label Jan 17, 2025
@cptartur cptartur moved this from New to Triage in Starknet foundry Jan 17, 2025
@cptartur cptartur moved this from Triage to Backlog in Starknet foundry Jan 17, 2025
@Nityam573
Copy link

@cptartur Can I work on this

@cptartur
Copy link
Member Author

Hey, this issue will be available for taking during the ODBoost https://app.onlydust.com/hackathons/odboost-1.
If you are still interested in tacking on this one, please apply after the ODBoost start tomorrow after 3 PM CET.

@codebestia
Copy link
Contributor

Can I work on this? @cptartur
I am a good blockchain developer with ample experience in rust.
I am new here and i will love to contribute to this project.

How i will handle this

  • I will fork this repo and create a new branch for the issue
  • I will follow the proposed instruction in this issue description to complete the task.
  • I will write test to verify that the --max-n-steps is displayed and i will update the existing tests to avoid breaking changes.
  • i will finish the task and open a PR within 48 hours of assignment.

@raizo07
Copy link

raizo07 commented Jan 22, 2025

Hello, I'd like to be assigned to work on this.
I’m a fullstack developer with over four years of experience.

ETA: 24 hours

@Thibrac
Copy link

Thibrac commented Jan 22, 2025

May I pick this up?

@khayss
Copy link
Contributor

khayss commented Jan 22, 2025

Could I be assigned to this?

@emarc99
Copy link

emarc99 commented Jan 22, 2025

Wow, wasn't even assigned any. Next time I guess

@Thibrac Thibrac linked a pull request Jan 23, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thibrac Thibrac

Labels
feature New feature request/description odboost: Easy ODBoost snforge
Projects
Starknet foundry
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: add information about the ability to use --max-n-steps Thibrac/starknet-foundry
7 participants
@cptartur @emarc99 @raizo07 @khayss @Nityam573 @codebestia @Thibrac