Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate default name while using account create #2709

Open
franciszekjob opened this issue Nov 25, 2024 · 25 comments · May be fixed by #2883
Open

Generate default name while using account create #2709

franciszekjob opened this issue Nov 25, 2024 · 25 comments · May be fixed by #2883
Assignees

Comments

@franciszekjob
Copy link
Collaborator

franciszekjob commented Nov 25, 2024

Which component is your feature related to?

Cast

Feature Request

In scope of this issue we should generate default account name when --name flag is not passed.
For example such command

sncast account create --url http://127.0.0.1:5055

should result in successful account creation.

It should use same logic as account import when --name is not provided.

@petersdt
Copy link

petersdt commented Nov 26, 2024

@franciszekjob @cptartur can i work on this task then

@franciszekjob
Copy link
Collaborator Author

Yes, @cptartur could you please assign the issue?
@petersdt do you need more context to do this task?

@petersdt
Copy link

@franciszekjob more context would help tanks

@franciszekjob
Copy link
Collaborator Author

franciszekjob commented Nov 26, 2024

@petersdt Ultimately, we should be able to use account create without passing --name flag. Name should be generated using this function. It's already done in account import so you can look up to it. Lmk if you need more details :).

@franciszekjob
Copy link
Collaborator Author

@petersdt Hi, how's the progress :) ?

@petersdt
Copy link

@franciszekjob am just about to start this task encountered some emergency that took me away for few days

but should be able to make something with 24hrs

@franciszekjob
Copy link
Collaborator Author

Hi @petersdt, do you have any updates?

@petersdt
Copy link

petersdt commented Dec 3, 2024

Hi @petersdt, do you have any updates?

sorry for the delay was trying to finish up on od10 but I have made a PR looking forward to your review.

@cptartur cptartur moved this from Backlog to In Progress in Starknet foundry Dec 3, 2024
@cptartur cptartur moved this from In Progress to Backlog in Starknet foundry Jan 14, 2025
@cptartur
Copy link
Member

Hey, this issue will be available for taking during the ODBoost https://app.onlydust.com/hackathons/odboost-1.
If you are still interested in tacking on this one, please apply after the ODBoost start tomorrow after 3 PM CET.

@RichoKD
Copy link

RichoKD commented Jan 22, 2025

Could I try solving this?

@khayss
Copy link
Contributor

khayss commented Jan 22, 2025

May I pick this up?

@TropicalDog17
Copy link

Hi, I'd like to work on this issue!
I have experience in Rust, and I have previously contribute to both Foundry and starknet-foundry repo in regular OSS contribution and ODHack hackathon.

@SoarinSkySagar
Copy link

may i start working on this issue @franciszekjob ?

background: cairo dev with 5 months of experience and regular contributor at @keep-starknet-strange

eta: 2 days

@bitfalt
Copy link

bitfalt commented Jan 22, 2025

Hi! I'd love to work on this issue. I would modify the crates/sncast/src/starknet_commands/account/create.rs file to ensure it uses the same logic as account import when --name is not provided.

I would read the code in crates/sncast/src/starknet_commands/account/import.rs to understand the logic to then implement it in the proper file for accout create

@Bosun-Josh121
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged:

software engineering background, backend & smart contract dev with contribution to similar tasks(https://app.onlydust.com/u/Bosun-Josh121) & great experience with cairo looking to make first contribution on this project

I have reviewed the linked implementation as directed, I am confident in implementing this

will work on feedback & recommendation ensuring contact. Can deliver within a day upon assignment

@ussyalfaks
Copy link

Can I take care of this issue?

@emarc99
Copy link

emarc99 commented Jan 22, 2025

I have experience contributing to sozo model binary package in the Dojo engine in Rust and Gold contributor on OD, so I am confident in achieving the task and testing for correct functionality.

@Elite-tch
Copy link

May I take care of this?

@fabrobles92
Copy link

Hello I am Fab Robles member of Dojo Coding and FullStack Developer, I have done contributions to several repos in Rust including Dojo Engine for the CLI sozo doing a similar feature for the one requested in this issue. I would love to contribute here :)

@onyedikachi-david
Copy link

May I handle this issue?

@1nonlypiece
Copy link

Application for Contribution

I am excited about the opportunity to contribute to this issue and am confident that my expertise aligns well with the requirements. With a strong background in Cairo programming and decentralized application development on StarkNet, I bring a well-rounded skill set to deliver an effective solution.

Relevant Expertise

  • Blockchain & Smart Contracts: Extensive experience with StarkNet, Stellar, and Rust, specializing in developing secure and optimized smart contracts, blockchain integrations, and high-performance backend infrastructure.
  • Backend Development: Well-versed in API design, server-side logic, and scalable system architecture, ensuring efficient and seamless backend performance.
  • Frontend Engineering: Skilled in crafting interactive and responsive UI components using React and Next.js, enhancing the user experience for blockchain-based platforms.

Why Consider My Application?

My proven track record of delivering high-quality, optimized solutions in blockchain and full-stack development sets me apart. I have a deep understanding of smart contract security, decentralized architectures, and the synergy between frontend, backend, and blockchain layers—ensuring a seamless and efficient implementation.

ETA

I expect to have a working solution ready within 48 hours. Please let me know if I can proceed with the implementation.

@od-hunter
Copy link
Contributor

Hi, please can I be assigned this please? I am a returning contributor and I would love to be given the opportunity to solve this issue please. I have experience in html, css, JavaScript, TypeScript, cairo and rust.

@RichoKD
Copy link

RichoKD commented Jan 23, 2025

Could I try solving this?

I'm on it

@franciszekjob
Copy link
Collaborator Author

Hi @RichoKD 👋 ,
how's the progress on this task 😄 ?

@RichoKD
Copy link

RichoKD commented Jan 27, 2025

Hi @RichoKD 👋 , how's the progress on this task 😄 ?

I'm still working on it, I'll open a draft PR soon

@RichoKD RichoKD linked a pull request Jan 27, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment