You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When compiling a library that uses MCAP internally it is good practice to hide MCAP api's, but the visibility attribute defines do not allow this https://github.com/foxglove/mcap/blob/main/cpp/mcap/include/mcap/visibility.hpp. It would be nice to make them overridable in order to avoid hacking the code in applications.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
When compiling a library that uses MCAP internally it is good practice to hide MCAP api's, but the visibility attribute defines do not allow this https://github.com/foxglove/mcap/blob/main/cpp/mcap/include/mcap/visibility.hpp. It would be nice to make them overridable in order to avoid hacking the code in applications.
Beta Was this translation helpful? Give feedback.
All reactions