Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remote-folder creation to the FractalSSHSlurmexecutor #1727

Closed
tcompa opened this issue Sep 4, 2024 · 0 comments · Fixed by #1728
Closed

Move remote-folder creation to the FractalSSHSlurmexecutor #1727

tcompa opened this issue Sep 4, 2024 · 0 comments · Fixed by #1728
Labels
runner ssh Issues related to the SSH mode of deployment

Comments

@tcompa
Copy link
Collaborator

tcompa commented Sep 4, 2024

(observed with @zonia3000)

When a job is marked as failed but the corresponding dataset has no history (because the error took place before running the first task), the error-displaying in the webclient can be improved - see fractal-analytics-platform/fractal-web#546.

Nevertheless, for the specific case that we hit this time, we can avoid the failed-job-with-no-dataset-history situation by implementing the suggestion in the FIXME in the following block

elif FRACTAL_RUNNER_BACKEND == "slurm_ssh":
WORKFLOW_DIR_REMOTE = (
Path(settings.FRACTAL_SLURM_SSH_WORKING_BASE_DIR)
/ WORKFLOW_DIR_LOCAL.name
)
# FIXME SSH: move mkdir to executor, likely within handshake
fractal_ssh.mkdir(
folder=str(WORKFLOW_DIR_REMOTE),
)
logger.info(f"Created {str(WORKFLOW_DIR_REMOTE)} via SSH.")
else:
logger.error(
"Invalid FRACTAL_RUNNER_BACKEND="
f"{settings.FRACTAL_RUNNER_BACKEND}."
)

@tcompa tcompa added ssh Issues related to the SSH mode of deployment runner labels Sep 4, 2024
@tcompa tcompa linked a pull request Sep 4, 2024 that will close this issue
3 tasks
tcompa added a commit that referenced this issue Sep 4, 2024
…mote-folder-creation-to-the-fractalsshslurmexecutor

Move SSH remote-folder creation to `_process_workkflow` (ref #1727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runner ssh Issues related to the SSH mode of deployment
Projects
1 participant