-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent tasks from setting an output attribute filter #2170
Comments
Originally posted by @tcompa in fractal-analytics-platform/fractal-tasks-core#866 (comment) |
We should certainly still allow tasks to set new attributes to be added to the image list (like it's done in the projection task). I still think it probably makes sense that tasks can't set attribute filters, given what we have planned for the attributes. I'm not aware of any task that would set its own attribute filters so far. The MIP task uses a |
You are right, thanks. I opened the issue as a self-reminder, before reviewing the current code, and I mixed up attributes and attribute filters.
I confirm that this is the case (at least for for fractal-tasks-core, scmultiplex and fractal-faim-ipa). |
Here a more systematic check - for these repositories $ cat repositories.txt
https://github.com/fractal-analytics-platform/fractal-tasks-core
https://github.com/fractal-analytics-platform/fractal-faim-ipa
https://github.com/leukemia-kispi/operetta-compose
https://github.com/fractal-analytics-platform/fractal-lif-converters
https://github.com/fractal-analytics-platform/fractal-helper-tasks
https://github.com/fmi-basel/gliberal-scMultipleX
https://github.com/m-albert/fractal-ome-zarr-hcs-stitching
https://github.com/pelkmanslab/abbott with this script #!/bin/bash
CURRENT_FOLDER=$(pwd)
for REPO in $(cat repositories.txt); do
echo "$REPO"
git clone $REPO tmpclone --quiet
cd tmpclone
git grep filters | grep "\.py"
cd $CURRENT_FOLDER
rm -rf tmpclone
echo
done Output:
TLDR
|
Makes sense. I guess most tasks that set output filters do this via manifest settings. The reason I did not do this with rechunking is that the rechunked type is a bit of an edge-case. And I'm only setting it if input data is not overwritten (=> it's not written in all cases). |
What if a task sets an output attribute filter? Do we even allow that? We probably should not
Types: First set by datasets type filters. Overwritten by workflow task input type filter. Workflow task output can set new types that overwrite both before.
Originally posted by @jluethi in #2155 (comment)
The text was updated successfully, but these errors were encountered: