Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge case: booleans are integer instances #2180

Open
ychiucco opened this issue Jan 15, 2025 · 0 comments
Open

Edge case: booleans are integer instances #2180

ychiucco opened this issue Jan 15, 2025 · 0 comments
Labels
flexibility Support more workflow-execution use cases

Comments

@ychiucco
Copy link
Collaborator

ychiucco commented Jan 15, 2025 •
edited
Loading 

DatasetCreateV2(
    name="x",
    zarr_dir="/x",
    attribute_filters={"key1": [1, True]},
)

should raise a ValidationError, since [1, True] should not be considered an homogeneous list, but

>>> isinstance(True, int)
True

(see tests/v2/01_schemas/test_schemas_dataset.py::test_invalid_attribute_filters).
@ychiucco ychiucco added the flexibility Support more workflow-execution use cases label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flexibility Support more workflow-execution use cases
Projects
Fractal Project Management
Status: TODO
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ychiucco