Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with coverage job in GitHub Action #881

Closed
tcompa opened this issue Dec 18, 2024 · 4 comments · Fixed by #892
Closed

Fix issue with coverage job in GitHub Action #881

tcompa opened this issue Dec 18, 2024 · 4 comments · Fixed by #892
Assignees
Labels
bug Something isn't working testing

Comments

@tcompa
Copy link
Collaborator

tcompa commented Dec 18, 2024

Right now, the coverage step of ci_poetry.yml uses version of coverage different from the one used in the test_tasks version, since the former comes from a pip install and the latter is the poetry-locked one. I guess this is the reason for the failures observed by @lorenzocerrone in #866.

Meanwhile, we should also bump the version to something a bit more recent (from 6.5 to 7.6).

@tcompa
Copy link
Collaborator Author

tcompa commented Dec 18, 2024

Closed with #882

@tcompa
Copy link
Collaborator Author

tcompa commented Dec 18, 2024

Note that the actual issue is still present in #866, and looks very similar to

@tcompa tcompa reopened this Dec 19, 2024
@tcompa tcompa changed the title Update coverage version and use it consistently in GHA Fix issue with coverage job in GitHub Action Dec 30, 2024
@tcompa
Copy link
Collaborator Author

tcompa commented Dec 30, 2024

We provisionally fixed this with 4c12f2b, but it's clearly suboptimal as it requires installing the whole package (pytorch included) just to produce the coverage.

@tcompa tcompa added the bug Something isn't working label Dec 30, 2024
@tcompa
Copy link
Collaborator Author

tcompa commented Jan 8, 2025

Ref nedbat/coveragepy#876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing
Projects
Development

Successfully merging a pull request may close this issue.

1 participant