Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend default handling from undefined-only to null/empty argument objects #540

Closed
tcompa opened this issue Jul 25, 2024 · 0 comments · Fixed by #535
Closed

Extend default handling from undefined-only to null/empty argument objects #540

tcompa opened this issue Jul 25, 2024 · 0 comments · Fixed by #535
Labels
dev/docs Developement tools and documentation JSON Schemas Editing of WorkflowTask arguments based on JSON Schemas

Comments

@tcompa
Copy link
Collaborator

tcompa commented Jul 25, 2024

Given #538, we have case A (arguments object is "empty" and fractal-web fills the defaults) and case B (arguments objects has values, and fractal-web ignore defaults).

Right now, case A actually requires arguments to be "undefined". We should extend it to cases where the object exists but is either null or {}.

This will also make the sandbox behavior (where undefined is sometimes found) more similar to the webclient (where the backend always sends something for the arguments property).

@tcompa tcompa added JSON Schemas Editing of WorkflowTask arguments based on JSON Schemas dev/docs Developement tools and documentation labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/docs Developement tools and documentation JSON Schemas Editing of WorkflowTask arguments based on JSON Schemas
Projects
1 participant