-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align with fractal-server 2.6.0 and 2.6.1 (re: user settings) #563
Comments
What about the "create new user" page? I assume that we should display only the first form. Once the user is created what should the page do? I see 2 possible alternatives:
|
Good point.
Yes, because (at least for the moment) the creation of a user always creates empty settings. I'd say your option 2 is better. After creating the user, the admin sees the second form where they can edit the user settings. |
A note for the backend: it seems that the |
I see that the endpoint |
Let's start like this:
If If if |
For the moment, let's disable the per-owner query - since we are in the process of dropping that attribute |
#563 (comment) was for the user profile, but we should also describe the admin-area side of this. Here is the full description admin-area / local or local_experimentalno attributes user's profile / local or local_experimentalno attributes admin-area / slurmeditable: slurm_user, cache_dir, slurm_accounts user's profile / slurmeditable: cache_dir, slurm_accounts admin-area / slurm_ssheditable: ssh_host, ssh_username, ssh_private_key_path, ssh_tasks_dir, ssh_jobs_dir, slurm_accounts user's profile / slurm_ssheditable: slurm_accounts |
In fractal-server 2.6, we will extract several attributes from the user table into a dedicated user-settings table, and we will also start including more attributes (which were currently global variables).
The main breaking changes in the API are in the `/auth/users/ routes.
slurm_user
,slurm_accounts
,cache_dir
) are not part of request/response bodies for GET/PATCH requests to/auth/users/{id}/
and/auth/current-user/
any more./auth/users/{id}/settings/
(for the admin) or/auth/current-users/settings/
(for the user).GET /auth/users/
orGET /auth/users/{id}/
) will automatically include a propertyuser.settings
, or whether this will have to go through a second API call./auth/current-user/
will not include asettings
property, but it will be required to make a second API call to/auth/current-user/settings/
PATCH /auth/current-user/
will decrease, or it may even be removed - TBD.Most internal changes concern the SLURM-related job execution and task collection, which are likely not tested in fractal-web CI.
In the webclient, we need to make changes in two parts:
Admin area
In the page where the admin can edit a single user, they should see two different forms: one to edit the user properties, and one to edit the user_settings one. Each form has a different "save" button.
User area
We should split the "profile" page into two pages: profile page (which is essentially read-only) and settings page (where the user can modify some values).
There is a decision to be taken about which settings to expose in the PATCH-related form. The database user-setting table has several columns, but only a subset of them are relevant. Which subset is relevant depends on a backend variable (
FRACTAL_RUNNER_BACKEND
). If we duplicate this env variable in fractal-web, then we can show a different form based on its value. Other ideas that do not rely on duplicating this variable are welcome.The text was updated successfully, but these errors were encountered: