Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error of missing banner file #633

Closed
tcompa opened this issue Nov 5, 2024 · 0 comments · Fixed by #634
Closed

Handle error of missing banner file #633

tcompa opened this issue Nov 5, 2024 · 0 comments · Fixed by #634

Comments

@tcompa
Copy link
Collaborator

tcompa commented Nov 5, 2024

When WARNING_BANNER_PATH=/something/banner.txt, but /something/banner.txt does not exist, we currently observe a ENOENT: no such file or directory error.

Another option would be to catch the error and simply have an error log, rather than the actual error raised. In that case, we would show no banner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Fractal Project Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added project dir setting and other changes fractal-analytics-platform/fractal-web
1 participant
@tcompa