Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[placeholder] Review what goes in "tasks" vs "manage tasks" pages #664

Closed
tcompa opened this issue Dec 3, 2024 · 4 comments
Closed

[placeholder] Review what goes in "tasks" vs "manage tasks" pages #664

tcompa opened this issue Dec 3, 2024 · 4 comments

Comments

@tcompa
Copy link
Collaborator

tcompa commented Dec 3, 2024

We should review what we currently have in each one of the two task lists, and decide which parts are duplicated and which parts are defined only in one of the two pages (and which one).


Based e.g. on #657 (comment):

Side comment (no action needed): where should the following feature live?

image

As part of #658, this is within the tasks-management page, which makes sense because that's the kind of separation we introduced (a read-only page that shows all available tasks, and one for the actual operations).

At some point in the future we may want to review this, and move the "Edit single task" button to the tasks list page. But I don't have a strong opinion here, and I would wait for some additional feedback (even after the merge&release).

In general I think that editing tasks should be quite rare, for the use flows that we typically have in mind.

@jluethi
Copy link
Collaborator

jluethi commented Dec 3, 2024

At some point in the future we may want to review this, and move the "Edit single task" button to the tasks list page. But I don't have a strong opinion here, and I would wait for some additional feedback (even after the merge&release).

I think it's well placed where it is. Editing tasks would be a task management operation. And it's good if the task management page has a simple overview of the task packages, while the main task page has our new fancy view on it :)

@tcompa
Copy link
Collaborator Author

tcompa commented Dec 3, 2024

Another question here is about the "info" modal.

In the "old" task-list page, clicking "info" shows a bunch of attributes (including commands, args schemas, ...), while the new tasks page only shows the docs info.

Is it OK this way, or should we add some more info into the modal of the new tasks page?

@jluethi
Copy link
Collaborator

jluethi commented Dec 3, 2024

Is it OK this way, or should we add some more info into the modal of the new tasks page?

That's a good question. For the moment, the separation works well for me. The core thing users care about is the task description. If we had more relevant Docs Link, they may also care about them. And some potential future content like longer description or images.

But all the other content like command, args schema version, meta, arg schemas etc. are correctly placed on the task management page, as they shouldn't be user-relevant

@tcompa
Copy link
Collaborator Author

tcompa commented Dec 3, 2024

Great. Let's revisit in the future if needed, or after some feedback on the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants