-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to add multiple values in dataset filters modal #689
Comments
We'll want to do a revision of this interface, especially given that we'll also use a similar view of the image list in the submission dialogue. I would imagine we use something more like the dropdowns in the image list. One functionality we may drop in this context is being able to filter for attributes that don't exist yet from the front-end. If we limit potential filters to just select from existing attributes, we already know the type of an attribute, we will already know all the potential values etc. |
There is a possible edge case that I don't know how to handle. Suppose to have an image with an attribute having key = Should I just ignore them and not display them to the UI? Another possibility could be to let the backend removing the invalid dataset filters when an image is deleted. |
Removal of image list entries should be rare. If we do hit that edge case, it's a good question on how we want to proceed. If we just keep the filter in place, it shouldn't interfere with any functionality. Because these attribute filters are "OR" inclusion filters, having e.g. 10 entries, only 9 of which really exist for key Thus, when an entry gets removed, I don't have a strong opinion on whether we keep showing the filter values. We'll always have to show all filter keys though. Re interface: |
A small question came up while reviewing this plan: Out of the two possible options ("all images" or "dataset filters" - see screenshot below), which one(s) should include the "save these filters into the dataset" button? |
Hmm, that's a good question. It seems natural to be able to modify the dataset filters and then save them. |
=> the "save these filters into the dataset" button should be available only for the "Dataset filters" option I guess. But we may want to think a bit further into how we make this something users can find. Some options are:
|
The new "Edit filters" button Clicking on the "Edit filters" button has the same effect of clicking on the "Dataset filters" button; the "Edit filters" button is replaced by a "Save filter" button; this button is disabled if there are no changes to save: The user can play with filters. When "Apply" is clicked the "Save filter" button becomes enabled: Then, when filters are saved: |
This is an interesting approach for it! I don't think placing the save filters button at the top makes sense anymore in this logic though. To me, save filters should be next to Apply & Reset. An alternative approach for the "All images" mode would then be to just have a greyed out "Save filters" with hover text like "Filters can only be saved in the "Dataset filters" mode"? |
Let's not show any filter edit buttons on the "All images" modal Let's rename the "Dataset filters" modal to: Potentially with a hover help message: "These are default selection for images on which a workflow will be run" "Save filters" becomes "Save". Let's also show a readme view of filters in info |
I moved the remaining open question to #708, and I'm closing this one. |
In the dataset page it should be possible to define a list of values for a given attribute filter key.
This could be implemented allowing to specify multiple times the same key:
Notice that this is currently not supported, since we are checking for duplicate keys:
Moreover, we should deny the creation of lists containing different types (e.g. not mixing strings and number).
At the moment we are supporting only the creation of lists containing a single value from this UI.
The text was updated successfully, but these errors were encountered: