Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in split_validation #168

Open
emmanuel-nwogu opened this issue May 10, 2023 · 1 comment
Open

Bug in split_validation #168

emmanuel-nwogu opened this issue May 10, 2023 · 1 comment
Assignees
@muellerdo
Labels
bug Something isn't working

Comments

@emmanuel-nwogu
Copy link

There is a bug in split_validation(): At this line, we create cb_list based on save_models but we never pass it to model.evaluate(). This means that your model will never be saved no matter what you pass in for save_models.

cc @muellerdo
@muellerdo muellerdo added the bug Something isn't working label May 10, 2023
@muellerdo muellerdo self-assigned this May 10, 2023
@muellerdo
Copy link
Member

You are absolutely right!
Thanks for spotting this bug. :)

I will try to fix it, ASAP.

Best Regards,
Dominik Müller

muellerdo added a commit that referenced this issue May 10, 2023
@muellerdo
Fixed callback passing bug in split_validation() - Closes #168
8f2b323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muellerdo muellerdo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@muellerdo @emmanuel-nwogu