Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Stravalib to latest post-1.2 version #45

Open
obscurerichard opened this issue Jan 13, 2024 · 1 comment · May be fixed by #75
Open

Update Stravalib to latest post-1.2 version #45

obscurerichard opened this issue Jan 13, 2024 · 1 comment · May be fixed by #75
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request help wanted Extra attention is needed no-rush-on-this-one

Comments

@obscurerichard
Copy link
Member

We are stuck at Stravalib 1.2.x until we rework code to eliminate some removed abstract interfaces. This follows up on #37
@obscurerichard obscurerichard added enhancement New feature or request help wanted Extra attention is needed no-rush-on-this-one dependencies Pull requests that update a dependency file labels Jan 13, 2024
@obscurerichard obscurerichard mentioned this issue Dec 31, 2024
Merged
obscurerichard added a commit that referenced this issue Jan 1, 2025
@obscurerichard
Upgrade stravalib from 1.2 to 2.1
1eb7207 
Upgrade `stravalib` from version 1.2 to 2.1 and refactor the code accordingly.

* **requirements.txt**
  - Update `stravalib` version to `2.1.0`.

* **freezing/sync/data/activity.py**
  - Update import statement for `Activity` to `DetailedActivity`.
  - Replace `Activity` with `DetailedActivity` in `update_ride_basic`, `write_ride_efforts`, `write_ride_photo_primary`, `update_ride_complete`, `check_activity`, `list_rides`, and `write_ride` methods.

* **freezing/sync/data/streams.py**
  - Update import statement for `Stream` to `StreamSet`.
  - Replace `Stream` with `StreamSet` in `write_ride_streams` method.

* **freezing/sync/utils/cache.py**
  - Update import statement for `Activity` to `DetailedActivity`.
  - Replace `Activity` with `DetailedActivity` in `CachingActivityFetcher` class.

Resolves #64
Resolves #45

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/freezingsaddles/freezing-sync?shareId=XXXX-XXXX-XXXX-XXXX).
@obscurerichard obscurerichard linked a pull request Jan 1, 2025 that will close this issue
Draft
@obscurerichard
Copy link
Member Author

#64 is not going to be enough on its own, #75 is the way

@obscurerichard obscurerichard moved this from Icebox to In progress in Freezing Saddles Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request help wanted Extra attention is needed no-rush-on-this-one
Projects
Freezing Saddles
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade stravalib from 1.2 to 2.1 freezingsaddles/freezing-sync
1 participant
@obscurerichard