Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Booleans with Helper::Row::ToJSON #88

Open
0x62ash opened this issue Jan 30, 2018 · 5 comments
Open

Booleans with Helper::Row::ToJSON #88

0x62ash opened this issue Jan 30, 2018 · 5 comments

Comments

@0x62ash
Copy link

0x62ash commented Jan 30, 2018

ToJSON should return JSON::PP::false, JSON::PP:true for boolean data-types.
@0x62ash
Copy link
Author

0x62ash commented Jan 30, 2018

Or maybe i should somehow bind my boolean column to JSON::PP::true/false objects...

@frioux
Copy link
Owner

frioux commented Feb 1, 2018

At this point making such a change would be backwards incompatible for anyone who has depended on the existing behavior for very long. I'd accept a PR to make it a flag though.

@mat813
Copy link

mat813 commented Aug 28, 2019

I was hit by this issue today, wondering how I could fix it :(

@frioux
Copy link
Owner

frioux commented Aug 28, 2019

Use the documented interface

@mat813
Copy link

mat813 commented Aug 29, 2019

Well, yes, I did that for the table I needed right away, but I was thinking more of a cleaner way in a helper :)
Don't worry, I'll figure out something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frioux @mat813 @0x62ash