Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language spec clarifications needed #841

Open
dsyme opened this issue Aug 24, 2020 · 2 comments
Open

Language spec clarifications needed #841

dsyme opened this issue Aug 24, 2020 · 2 comments

Comments

@dsyme
Copy link
Contributor

dsyme commented Aug 24, 2020

@NinoFloris
Copy link

Maybe also fixes from dotnet/fsharp#9858 (comment)

Spec defines custom op with bind as:

T([<CustomOperator("Cop", MaintainsVarSpaceUsingBind=true)>]cop arg; e, V, C, q) = Assert (q);
CL(cop arg; e, V, C(b.Return exp(V)), false)

First off MaintainsVarSpaceUsingBind should read MaintainsVariableSpaceUsingBind

Then looking at the definition of CL we see

Specifically:

bind: indicator if it is for Bind (true) or iterator (false).

Yet the definition of custom op with bind states false for bind while it should clearly be true.

I also believe the definition right after it

T([<CustomOperator("Cop")>]cop arg; e, V, C, q) = Assert (q); CL(cop arg; e, V, C(b.Yield exp(V)), false)

Should instead be

T([<CustomOperator("Cop", MaintainsVariableSpace=true)>]cop arg; e, V, C, q) = Assert (q); CL(cop arg; e, V, C(b.Yield exp(V)), false)

@dsyme
Copy link
Contributor Author

dsyme commented Aug 25, 2020

Yes, thanks, that one too, I've added it to the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants