We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A list of spec clarifications needed:
dotnet/fsharp#9762 (comment)
dotnet/fsharp#9913
dotnet/fsharp#9806 (comment)
dotnet/fsharp#9858 (comment)
dotnet/fsharp#6132 (comment)
dotnet/fsharp#3580
dotnet/fsharp#6136
dotnet/fsharp#9692
fsharp/fslang-suggestions#916
#597
dotnet/fsharp#3566
The text was updated successfully, but these errors were encountered:
Maybe also fixes from dotnet/fsharp#9858 (comment)
Spec defines custom op with bind as: T([<CustomOperator("Cop", MaintainsVarSpaceUsingBind=true)>]cop arg; e, V, C, q) = Assert (q); CL(cop arg; e, V, C(b.Return exp(V)), false) First off MaintainsVarSpaceUsingBind should read MaintainsVariableSpaceUsingBind Then looking at the definition of CL we see Specifically: bind: indicator if it is for Bind (true) or iterator (false). Yet the definition of custom op with bind states false for bind while it should clearly be true. I also believe the definition right after it T([<CustomOperator("Cop")>]cop arg; e, V, C, q) = Assert (q); CL(cop arg; e, V, C(b.Yield exp(V)), false) Should instead be T([<CustomOperator("Cop", MaintainsVariableSpace=true)>]cop arg; e, V, C, q) = Assert (q); CL(cop arg; e, V, C(b.Yield exp(V)), false)
Spec defines custom op with bind as:
T([<CustomOperator("Cop", MaintainsVarSpaceUsingBind=true)>]cop arg; e, V, C, q) = Assert (q); CL(cop arg; e, V, C(b.Return exp(V)), false)
First off MaintainsVarSpaceUsingBind should read MaintainsVariableSpaceUsingBind
Then looking at the definition of CL we see
Specifically:
bind: indicator if it is for Bind (true) or iterator (false).
Yet the definition of custom op with bind states false for bind while it should clearly be true.
I also believe the definition right after it
T([<CustomOperator("Cop")>]cop arg; e, V, C, q) = Assert (q); CL(cop arg; e, V, C(b.Yield exp(V)), false)
Should instead be
T([<CustomOperator("Cop", MaintainsVariableSpace=true)>]cop arg; e, V, C, q) = Assert (q); CL(cop arg; e, V, C(b.Yield exp(V)), false)
Sorry, something went wrong.
Yes, thanks, that one too, I've added it to the list
@
No branches or pull requests
A list of spec clarifications needed:
dotnet/fsharp#9762 (comment)
dotnet/fsharp#9913
dotnet/fsharp#9806 (comment)
dotnet/fsharp#9858 (comment)
dotnet/fsharp#6132 (comment)
dotnet/fsharp#3580
dotnet/fsharp#6136
dotnet/fsharp#9692
fsharp/fslang-suggestions#916
#597
dotnet/fsharp#3566
The text was updated successfully, but these errors were encountered: