Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump aiobotocore to 2.6.0 #801

Closed
jayzfbn opened this issue Sep 27, 2023 · 14 comments
Closed

bump aiobotocore to 2.6.0 #801

jayzfbn opened this issue Sep 27, 2023 · 14 comments

Comments

@jayzfbn
Copy link
Contributor

jayzfbn commented Sep 27, 2023

May I request a bump of aiobotocore dependency to ~=2.6.0 which was released over a month ago? I'm happy to submit a PR if that's desired.

@martindurant
Copy link
Member

Unfortunately, conda-forge/aiobotocore-feedstock#68 is still not resolved.

@martindurant
Copy link
Member

I stand corrected! conda-forge/aiobotocore-feedstock#69 built yesterday, but my issue was not mentioned or closed. Please do make a PR.

@jayzfbn
Copy link
Contributor Author

jayzfbn commented Sep 27, 2023

#802

@jayzfbn
Copy link
Contributor Author

jayzfbn commented Sep 27, 2023

I apologize ahead of time if there should be more to the PR; I am not particularly familiar with this dependency tree I just happened to bump into s3fs blocking an update to aiobotocore 2.6.0 on a project.

@jayzfbn
Copy link
Contributor Author

jayzfbn commented Oct 3, 2023

Not at all urgent, but I thought I'd ping to see if a release with this was on the radar any time soon. Thx!

@martindurant
Copy link
Member

I imagine around mid-month, unless there is some pressing issue.

@Nepherhotep
Copy link

Hi @martindurant, is there any timeline, when the new release with aiobotocore==2.6.0 is going to be published?

@Nepherhotep
Copy link

At the moment, it's a combination of s3fs + moto + aiobotocore, which don't want to work together.

@martindurant
Copy link
Member

I see I am perhaps a little overdue...
Still, I'm sure you can find a combination that works, since the CI in this very repo is still fine and uses those components. It's usually installing boto3 after s3fs that causes problems.

@paulmueller
Copy link

paulmueller commented Oct 17, 2023

aiobotocore 2.7.0 has just been released which now supports urllib3>=2. There has been a trail of dependencies that has led me here:

Could you please bump aiobotocore to 2.7.0 instead? This would make everything work with the latest version of urllib3 on at least Python 3.10.

EDIT: 2.7.0 might not be enough (for me) due to strange dependency pinning in boto3 (aio-libs/aiobotocore#1037 (comment)) the fact that shortly after aiobotocore, there has been a new release of boto3 and botocore.

@martindurant
Copy link
Member

Please make a PR with the change, and we will see if anything breaks. I

@Nepherhotep
Copy link

I see I am perhaps a little overdue... Still, I'm sure you can find a combination that works, since the CI in this very repo is still fine and uses those components. It's usually installing boto3 after s3fs that causes problems.

I'm using Pipenv to build a dependency graph first, so the installation order is not important. I feel like the version from main branch looks good, though.

@jayzfbn
Copy link
Contributor Author

jayzfbn commented Oct 20, 2023

Just thought I would bump this again to see if we can get a release cut. We'd be fine with either aiobotocore 2.6.0 or 2.7.0 but we have a few things waiting on it now and I'd much rather use the public release than patch something. Thanks!

@paulmueller
Copy link

As far as I can tell, s3fs 2023.10.0 has the following requirements.txt:

aiobotocore~=2.7.0
fsspec==2023.10.0
aiohttp!=4.0.0a0, !=4.0.0a1

👍

This means this issue can probably be closed.

@jayzfbn jayzfbn closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants