Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Line UI] Bug with handle movement when page has scrolled. #192

Open
atomworks opened this issue Oct 11, 2021 · 1 comment
Open

[Line UI] Bug with handle movement when page has scrolled. #192

atomworks opened this issue Oct 11, 2021 · 1 comment
Assignees
Labels
bug Something isn't working Investigation Needed

Comments

@atomworks
Copy link
Collaborator

atomworks commented Oct 11, 2021

Overview

When scrolling a page with the UI line drawing tool the handles become Y-offset against the mouse position when dragging a handle.

I'm sure we've fixed this bug before so I'm not sure why it's back on this project. The project using this is using 1.5.4 but since then it seems no code has change in the LineUI. There is a slight chance this is due to some implementation on the project side as they are toggling between a read-only and dragging variation but it's best to investigate and confirm this in isolation first as I expect it's most likely an issue on the UI Kit side.

Investigation

Looking at this issue it's a bug where by when the body scrolls it changes the co-ordinates being reported causing handles to become detached. It seems that many of our use cases currently have their own divs that scroll internally for this view and so the body doesn't actually move, so previously we may have used this behaviour as a fix. However, it's something we should fix on the UI Kit side.

How to recreate.

Just add a basic line drawing instance to an empty page and wrap it in a container with a fixed height of 200vh (for example). Then you can scroll and recreate this behaviour.

@atomworks atomworks added the bug Something isn't working label Oct 11, 2021
@atomworks
Copy link
Collaborator Author

I just test this thinking we fixed it a long time ago and it's still an issue. We might want to address this one sooner, perhaps while reviewing the component.

Some of the newer patterns planned will need this to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Investigation Needed
Projects
None yet
Development

No branches or pull requests

2 participants