Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Feature Request:- Being able to use either url or domain as marker #22

Open
vipulbhj opened this issue Oct 28, 2019 · 6 comments
Open
Labels
enhancement New feature or request hacktoberfest

Comments

@vipulbhj
Copy link
Collaborator

In the options page, we should support an option to either mark a specific url or a domain itself to be used as mark incognito and based on that the interception algorithm should change for those given assets.

Use Case : -

For blogging websites like Medium, I want to open all urls from that domain in incognito mode and this feature will give us the flexibility to do that. This will also be useful in banking, etc.

The implementation can be done in a few different ways
@fxnoob @HurricaneInteractive @0xflotus
let me know what do you guys think about this feature and if you wanna discuss the best way forward.

@vipulbhj vipulbhj added enhancement New feature or request hacktoberfest labels Oct 28, 2019
@vipulbhj vipulbhj changed the title Feature Request Feature Request:- Being able to use either url or domain as marker Oct 28, 2019
@HurricaneInteractive
Copy link
Contributor

That does sound like a really good idea. (I haven't seen / worked on the options page) My first idea would be to store more information with the link. In this case almost a "wildcard". I know the chrome storage is a key/value, however, you can always JSON.stringify and then convert it back.

Then when the comparing is done, you'll test if it is a wildcard match or just a full URL match and proceed with the opening in incognito or ignore the link.

@fxnoob
Copy link
Owner

fxnoob commented Oct 28, 2019

Best way should be to store more information with the link as @HurricaneInteractive said. So store original url with one more property named as all eg. {url:"", all:"true|false"}. so there would be two option in context menu 1 for saving the domain and 2 would be for saving exact url. Please revert the changes from unchanged files eg. option-page files.

@fxnoob
Copy link
Owner

fxnoob commented Oct 29, 2019

@vipulbhj are you working on suggested changes?

@vipulbhj
Copy link
Collaborator Author

@fxnoob didn't get any time today. I be back on regular schedule from tomorrow.

@fxnoob
Copy link
Owner

fxnoob commented Nov 2, 2019

Screenshot 2019-11-02 at 8 02 58 PM
@vipulbhj, Is this ok view?

@vipulbhj
Copy link
Collaborator Author

vipulbhj commented Nov 2, 2019

Yes, looks great
:)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants