Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for secret passing #41

Open
elsalant opened this issue Jun 15, 2022 · 1 comment
Open

Support for secret passing #41

elsalant opened this issue Jun 15, 2022 · 1 comment
Assignees

Comments

@elsalant
Copy link
Contributor

elsalant commented Jun 15, 2022

@cdoron
Some Airbyte connectors, like S3, will require that secrets be passed to them. Currently, the only way this could be done is to put the secret keyword and value in the Asset yaml where they will eventually end up in a mounted file (/etc/conf/conf.yaml) This is of course a security hole. Instead, the secrets - keyword as expected by the Airbyte connector and values - either be stored in Vault or in a Secrets asset and the module should then extract these, append them to the other values specified in Asset yaml and pass these as configuration parameters to the airbyte connector.

@cdoron
Copy link
Collaborator

cdoron commented Aug 23, 2022

@elsalant : how urgent is this issue?

I think that the best way to address this problem is using Vault, and the Fybrik python vault library: https://github.com/fybrik/fybrik/tree/master/python/vault

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants