Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fyne package is removing built executables #5437

Open
2 tasks done
andydotxyz opened this issue Jan 20, 2025 · 3 comments
Open
2 tasks done

Fyne package is removing built executables #5437

andydotxyz opened this issue Jan 20, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@andydotxyz
Copy link
Member

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

The package command is using the build command which will remove existing build files in PWD...

Instead it should build to a temporary directory so we don't overwrite build files or other files with the same name.

Info extracted from a conversation with @hkparker.

How to reproduce

  1. fyne build and see your executable
  2. fyne package and you will see a package but the executable is gone.

Note that this will not be recognisable on Windows because they have the same file name.

This also happens with conflicting builds for different platforms, such as a Linux host running fyne build and then fyne package -os android.

Screenshots

No response

Example code

n/a

Fyne version

2.5.3 and develop

Go compiler version

all

Operating system and version

macOS/Linux

Additional Information

No response

@andydotxyz andydotxyz added unverified A bug that has been reported but not verified bug Something isn't working and removed unverified A bug that has been reported but not verified labels Jan 20, 2025
@andydotxyz andydotxyz added this to the "F" release, Early 2025 milestone Jan 20, 2025
@Jacalz
Copy link
Member

Jacalz commented Jan 21, 2025

I wonder if this should be in the tools repo instead? I think we really need to double down and do that transition for v2.6.0 if we want to move towards a v3.0.0 and be able to clean out the command from this repo by then.

@hkparker
Copy link
Contributor

I originally noticed that fyne package, when creating an android app on linux, was deleting the linux binary, I just now noticed that fyne serve on linux deletes the binary as well.

@Jacalz
Copy link
Member

Jacalz commented Jan 23, 2025

Yes, all of them build to the current directory. Should be quite an easy fix, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants