Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Issue] Secret Detected in Repository #39

Closed
MrJackQiao opened this issue Dec 13, 2024 · 2 comments
Closed

[Security Issue] Secret Detected in Repository #39

MrJackQiao opened this issue Dec 13, 2024 · 2 comments

Comments

@MrJackQiao
Copy link

Hi,

We are a team of security researchers from the University of Delaware in the United States. We are reaching out to notify you that one of the files in the repository contains secrets in plain text. It is crucial that the secrets are set up properly to safeguard the integrity and security of your system and its users.

Please reach out to [email protected] for more information.

Best regards,
UD X-Lab

@GabLeRoux
Copy link
Member

Hi,
Thank you for bringing this to our attention. I’ve sent an email to follow up on this issue. We appreciate your responsible disclosure.

@webbertakken
Copy link
Member

Fixed in #40.

To be fair though: CodeCov didn't use to have the "tokenless" option when this was implemented and you had two options:

  • Either you paste the token in your workflow so that the diff correctly shows up for all contributors
  • Or you use it as a secret, which means that nobody outside the org will get coverage diffs in their PRs, as per the secrets not being passed to workflows running on forks

In practice this was a trade-off and we never considered it to be a real security concern.

I'd also kindly ask you to follow security policy or email maintainers directly instead of immediately publicly exposing security related information (i.e. that there is a secret to find in the repo). We might not always be quicker to respond than people with bots that scrape GitHub for the word "security issue". 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants