Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Item does not reflect in Multiplayer death messages #6

Open
ghost opened this issue May 7, 2021 · 1 comment
Open

Renamed Item does not reflect in Multiplayer death messages #6

ghost opened this issue May 7, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented May 7, 2021

The name of the renamed weapon when someone is killed by them is not properly reflected in death messages.

Recreating

  1. Head onto a server with two users
  2. Rename any weapon of your choice
  3. Slay your foe with the renamed weapon
  4. Read the death message. Does not reflect weapon's name.
@gamrguy
Copy link
Owner

gamrguy commented May 7, 2021

This is due to how Terraria generates death messages.
When generating a death message, the item's actual data is not referenced - instead, only the item ID is sent to the death message generator. (The item's prefix ID is passed around in the netcode, but doesn't appear to actually get used.)

I think I may be able to bypass this behavior with the proper methods, however with my current understanding of the code I'm not certain if I can get it to work reliably without extra effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant