Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native 0.29+ compatibility #12

Open
awinogrodzki opened this issue Aug 11, 2016 · 3 comments
Open

React Native 0.29+ compatibility #12

awinogrodzki opened this issue Aug 11, 2016 · 3 comments

Comments

@awinogrodzki
Copy link

awinogrodzki commented Aug 11, 2016

There is some issues with Socket.swift file which is deprecated with the newest version of RN and Swift, this sometimes causes crashes in development environment and prevents smooth debugging. Also I had many issues to install the libraries with Xcode. Maybe it's a good idea to use RNPM library to link it automatically?

@kitolog
Copy link

kitolog commented Sep 7, 2016

How did you solve the issues in Socket.swift?

@kitolog
Copy link

kitolog commented Sep 7, 2016

I got ...react-native-socketio/ios/RNSwiftSocketIO/Socket.swift:67:21: Method 'eventDispatcher' was used as a property; add () to call it

@saalihou
Copy link

I made a PR that makes this library compatible with RN 0.29+ plus some other things like multiple event handlers/socket support: #46
Hope it lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants